New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating duplicate sheet names should error #145

Closed

yha opened this issue Aug 2, 2020 · 1 comment

Assignees

Labels

bug

yha commented Aug 2, 2020 •

edited

Loading

rename! to an existing name should error. Instead it creates an xlsx which Excel "recovers" by renaming some sheets. Example:

XLSX.openxlsx("tmp.xlsx", mode="w") do xf
    sh1 = XLSX.addsheet!(xf)
    sh2 = XLSX.addsheet!(xf)
    XLSX.rename!(sh1,"foo")
    XLSX.rename!(sh2,"foo")
end

The text was updated successfully, but these errors were encountered:

felipenoris self-assigned this

felipenoris added the bug label

Owner

felipenoris commented Aug 2, 2020

@yha thanks for finding this bug!

felipenoris added a commit that referenced this issue


          duplicate sheetname should error (#145)

dbc9563

felipenoris closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment