Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NAK data corruption #470

Closed
wants to merge 1 commit into from
Closed

Fix NAK data corruption #470

wants to merge 1 commit into from

Conversation

gdsports
Copy link
Contributor

See #403

@gdsports gdsports mentioned this pull request Jul 1, 2019
Open
@Lauszus
Copy link
Collaborator

Lauszus commented Jul 2, 2019

Looks good to me. @felis okay to merge?

@gdsports
Copy link
Contributor Author

gdsports commented Jul 2, 2019

Hold off merging this because a different fix will make this unnecessary. Fixing #462 should also fix this problem. Both problems have the same root cause.

@xxxajk
Copy link
Contributor

xxxajk commented Jul 2, 2019

I have the patch, just waiting for credentials to push it.

@felis
Copy link
Owner

felis commented Jul 3, 2019

@Lauszus please do. Thanks everybody!

@gdsports gdsports mentioned this pull request Jul 3, 2019
Merged
@gdsports
Copy link
Contributor Author

gdsports commented Jul 3, 2019

Superceded by #473

@gdsports gdsports closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gdsports @Lauszus @xxxajk @felis