Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append the individual elements of select args, not the slice #6

Merged
merged 2 commits into from Sep 2, 2021
Merged

Append the individual elements of select args, not the slice #6

merged 2 commits into from Sep 2, 2021

Conversation

allanglen
Copy link
Contributor

@allanglen allanglen commented Sep 2, 2021 •
edited

When appending the computed arguments from a select, the slice of arguments was being appended, not the individual elements.

Note that this also resolves the TestExampleTestSuite/TestFundamentals/Applying_filters that has been failing.

@fenos
Copy link
Owner

fenos commented Sep 2, 2021

Thanks a lot @allanglen

@fenos fenos merged commit e8c319a into fenos:main Sep 2, 2021
@fenos
Copy link
Owner

fenos commented Sep 2, 2021

released in v0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allanglen @fenos