Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: existing locales in crowdin #562

Merged
merged 3 commits into from
Aug 21, 2022
Merged

fix: existing locales in crowdin #562

merged 3 commits into from
Aug 21, 2022

Conversation

SpecialAro
Copy link
Member

@SpecialAro SpecialAro commented Aug 19, 2022 •
edited
Loading

Pre-flight Checklist

  1. Please remember that if you are logging a bug for some service that has stopped working or is working incorrectly, please log the bug here
  2. If you are requesting support for a new service in Ferdium, please log it here
  3. Please remember to read the self-help documentation - in case it helps you unblock yourself for issues related to older versions of recipes that were installed on your machine. (These will get automatically upgraded when you upgrade to the newer versions of Ferdium, but to get new recipes between Ferdium releases, this documentation is quite useful.)
  4. Please ensure you've completed all of the following.

Description of Change

Add existing locales to UI that are also existent in crowdin.

Motivation and Context

This PR tries to make an advance with #185 by adding to the UI the languages that are in the locales folder and also in Crowdin.

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (npm run prepare-code)
  • npm test passes
  • I tested/previewed my changes locally

Release Notes

notes: Adds language support for Vietnamese, Arabic, Finnish, Hebrew, Korean, Norwegian, Romanian, Sinhala and Swedish. Note that the percentage of each translation can be found in: https://crowdin.com/project/ferdium-app

@SpecialAro SpecialAro requested review from vraravam, nathanaelhoun and a team August 19, 2022 01:35
@SpecialAro SpecialAro self-assigned this Aug 19, 2022
cino
cino reviewed Aug 19, 2022
View reviewed changes
src/i18n/languages.ts Outdated Show resolved Hide resolved
nathanaelhoun
nathanaelhoun suggested changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@nathanaelhoun nathanaelhoun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SpecialAro for this! Could you sort alphabetically the keys in the list please?

@nathanaelhoun nathanaelhoun mentioned this pull request Aug 21, 2022
Closed
3 tasks
@nathanaelhoun nathanaelhoun changed the base branch from develop to l10n_develop August 21, 2022 17:58
@nathanaelhoun nathanaelhoun merged commit 413f883 into ferdium:l10n_develop Aug 21, 2022
nathanaelhoun
nathanaelhoun reviewed Aug 21, 2022
View reviewed changes
Copy link
Contributor

@nathanaelhoun nathanaelhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort alphabetically the keys in the list please?

Nvm, they was not sorted in the first place

nathanaelhoun added a commit that referenced this pull request Aug 21, 2022
@SpecialAro @nathanaelhoun
fix: existing locales in crowdin (#562)
efdd20c 
* fix: existing locales in crowdin

* fix(i18n): back to Nederlands for nl

Co-authored-by: Nathanaël Houn <contact@nathanaelhoun.fr>
@SpecialAro SpecialAro deleted the lang-track branch August 21, 2022 19:06
nathanaelhoun added a commit that referenced this pull request Aug 22, 2022
@vraravam @nathanaelhoun
@SpecialAro @andrii-bodnar
feat: translations with Crowdin
602790d 
* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (German)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Japanese)

* New translations en-US.json (Dutch)

* New translations en-US.json (German)

* New translations en-US.json (Dutch)

* New translations en-US.json (Dutch)

* New translations en-US.json (Dutch)

* New translations en-US.json (Italian)

* New translations en-US.json (Italian)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Dutch)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Dutch)

* New translations en-US.json (Dutch)

* New translations en-US.json (Spanish)

* chore: removed typoed pr-BR.json translation file

* i18n: skip unstranslated strings in crowdin export

* New translations en-US.json (Romanian)

* New translations en-US.json (Chinese Traditional)

* New translations en-US.json (Russian)

* New translations en-US.json (Slovak)

* New translations en-US.json (Serbian (Cyrillic))

* New translations en-US.json (Swedish)

* New translations en-US.json (Turkish)

* New translations en-US.json (Ukrainian)

* New translations en-US.json (Chinese Simplified)

* New translations en-US.json (Vietnamese)

* New translations en-US.json (Polish)

* New translations en-US.json (Portuguese, Brazilian)

* New translations en-US.json (Indonesian)

* New translations en-US.json (Persian)

* New translations en-US.json (Croatian)

* New translations en-US.json (Hindi)

* New translations en-US.json (Flemish)

* New translations en-US.json (Bosnian)

* New translations en-US.json (Portuguese)

* New translations en-US.json (Norwegian)

* New translations en-US.json (French)

* New translations en-US.json (German)

* New translations en-US.json (Spanish)

* New translations en-US.json (Afrikaans)

* New translations en-US.json (Arabic)

* New translations en-US.json (Belarusian)

* New translations en-US.json (Catalan)

* New translations en-US.json (Czech)

* New translations en-US.json (Danish)

* New translations en-US.json (Greek)

* New translations en-US.json (Finnish)

* New translations en-US.json (Irish)

* New translations en-US.json (Hebrew)

* New translations en-US.json (Hungarian)

* New translations en-US.json (Italian)

* New translations en-US.json (Japanese)

* New translations en-US.json (Georgian)

* New translations en-US.json (Korean)

* New translations en-US.json (Sinhala)

* New translations en-US.json (Flemish)

* New translations en-US.json (Czech)

* i18n: add automatically_fill_regional_dialects in crowdin.yml

* fix: existing locales in crowdin (#562)

* fix: existing locales in crowdin

* fix(i18n): back to Nederlands for nl

Co-authored-by: Nathanaël Houn <contact@nathanaelhoun.fr>

* fix: add Crowdin languages mapping in config file (#284)

Fix: Crowdin languages mapping

Co-authored-by: Nathanaël Houn <contact@nathanaelhoun.fr>

* feat(i18n): customize PR title and commits

* Pulled down update to recipes submodule

* New translations en-US.json (French)

Co-authored-by: Nathanaël Houn <contact@nathanaelhoun.fr>
Co-authored-by: André Oliveira <37463445+SpecialAro@users.noreply.github.com>
Co-authored-by: Andrii Bodnar <29282228+andrii-bodnar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cino cino cino left review comments

@nathanaelhoun nathanaelhoun nathanaelhoun requested changes

@vraravam vraravam Awaiting requested review from vraravam

Assignees

@SpecialAro SpecialAro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpecialAro @cino @nathanaelhoun