Revved version of the GCP TF Provider #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Eberts <nickeberts@google.com>
FrankYang0529
suggested changes
Aug 10, 2022
share/terraform/scripts/startup.sh
Outdated
| @@ -118,5 +117,9 @@ export HIPPO_FOLDER='${home_path}/hippo/linux-x64' | |||
| export DNS_ZONE='${dns_zone}' | |||
| export ENABLE_LETSENCRYPT='${enable_letsencrypt}' | |||
|
|
|||
| echo "Copying vm_assets to local instance" | |||
| gsutil cp -r ${storage_bucket_path}/* ./ | |||
There was a problem hiding this comment.
I haven't tested this, but this shared script works for AWS and DigitalOcean too. Probably, it's not good to use GCP specific command here.
There was a problem hiding this comment.
Gotcha. Slimmed down the PR to JUST update the TF GCP version.
Signed-off-by: Nicholas Eberts <neberts12@gmail.com>
Signed-off-by: Nicholas Eberts <neberts12@gmail.com>
| @@ -30,7 +30,7 @@ variable "instance_name" { | |||
| variable "instance_type" { | |||
| description = "The type of VM Instance to run for each node in the cluster (Default: g1-small)" | |||
| type = string | |||
| default = "g1-small" | |||
| default = "e1-small" | |||
There was a problem hiding this comment.
May you share where did you find e1-small type? I tried to find it at https://gcpinstances.doit-intl.com/, but it's not there.
Also, please help to change related terms at line 31 Default: e1-small and README.md under gcp folder. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96
Updated the GCP TF Provider to "4.31.0".
Ran in to issues with SSH keys. I think the GCE resource was changed to support OS login in-between 3.5 and 4.31.
Reworked the SSH login to use GCP OS Login by:
Two additional small changes: