chore!: update wasmtime and wit-bindgen dependencies
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm leaving this as a draft until after Spin 0.3.0 is tagged since I don't want to complicate that release. |
|
I'll investigate the Go SDK test failure. |
`wasmtime` 0.35.3 is, as of this writing, the most recent version of `wasmtime` that supports module linking. Later versions have removed module linking in favor of the component model, but the component model work is still in progress, so we can't upgrade to the very latest until that work is complete. BREAKING CHANGE: This also updates `wit-bindgen` to a snapshot of the main branch as of June 13th. Known breaking changes from that update include: - breaking ABI changes -- you'll need to rebuild modules using a matching `wit-bindgen` - "function" has been renamed to "func" in WIT files - pull- and push-buffer support has been removed Due to the latter, I've removed `crates/object-store` from this repo temporarily. We can add it back in once stream support has been implemented in `wit-bindgen`. Note that I've regenerated the Go SDK using the new `wit-bindgen`. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
wasmtime-wit-bindgen-update
branch
from
3d4c84a
to
9bd4a48
Compare
|
Test failure is fixed, thanks to help from @adamreese. The Go SDK needed to be regenerated using the new |
lann
approved these changes
Jun 16, 2022
Closed
This was referenced Jul 6, 2022
dicej
added a commit
to dicej/spin
that referenced
this pull request
Jul 25, 2022
- The spin-cli build was broken due to API changes in the main branch of the hippo-cli repo. I've switched to using a recent tag to ensure it doesn't break again unexpectedly. - The http-cpp build has been broken since fermyon#574 was merged. My bad for not noticing until now. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
added a commit
to dicej/spin
that referenced
this pull request
Jul 25, 2022
- The spin-cli build was broken due to API changes in the main branch of the hippo-cli repo. I've switched to using a recent tag to ensure it doesn't break again unexpectedly. - The http-cpp build has been broken since fermyon#574 was merged. My bad for not noticing until now. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
added a commit
to dicej/spin
that referenced
this pull request
Jul 26, 2022
- The spin-cli build was broken when executed via `cargo install` since [`cargo install` ignores Cargo.lock](rust-lang/cargo#7169) and the main branch of the `hippo-cli` repo is currently incompatible with `spin deploy` due to API changes. I've fixed this by copying the Cargo.lock revision into Cargo.toml. Once fermyon#621 is merged we'll start using a proper tag instead. - The http-cpp build has been broken since fermyon#574 was merged. My bad for not noticing until now. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasmtime0.35.3 is, as of this writing, the most recent version ofwasmtimethat supports module linking. Later versions have removed module linking in
favor of the component model, but the component model work is still in progress,
so we can't upgrade to the very latest until that work is complete.
BREAKING CHANGE: This also updates
wit-bindgento a snapshot of the mainbranch as of June 13th. Known breaking changes from that update include:
breaking ABI changes -- you'll need to rebuild modules using a matching
wit-bindgen"function" has been renamed to "func" in WIT files
pull- and push-buffer support has been removed
Due to the latter, I've removed
crates/object-storefrom this repotemporarily. We can add it back in once stream support has been implemented in
wit-bindgen.Signed-off-by: Joel Dice joel.dice@fermyon.com