fix spin-cli and http-cpp builds #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dicej
force-pushed
the
fix-cli-and-http-cpp
branch
from
055c130
to
916659f
Compare
- The spin-cli build was broken when executed via `cargo install` since [`cargo install` ignores Cargo.lock](rust-lang/cargo#7169) and the main branch of the `hippo-cli` repo is currently incompatible with `spin deploy` due to API changes. I've fixed this by copying the Cargo.lock revision into Cargo.toml. Once fermyon#621 is merged we'll start using a proper tag instead. - The http-cpp build has been broken since fermyon#574 was merged. My bad for not noticing until now. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
force-pushed
the
fix-cli-and-http-cpp
branch
from
916659f
to
4fea4a0
Compare
fibonacci1729
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spin-cli build was broken when executed via
cargo installsincecargo installignores Cargo.lock and the main branch of thehippo-clirepo is currently incompatible withspin deploydue to API changes. I've fixed this by copying the Cargo.lock revision into Cargo.toml. Once bump to hippo-openapi 0.9, hippo v0.14.1 #621 is merged we'll start using a proper tag instead.The http-cpp build has been broken since chore!: update
wasmtimeandwit-bindgendependencies #574 was merged. My bad for not noticing until now.Signed-off-by: Joel Dice joel.dice@fermyon.com