Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address linting & protobuf issues #149

Merged
merged 10 commits into from
Jun 27, 2023
Merged

Conversation

Jonathansumner
Copy link
Member

@Jonathansumner Jonathansumner commented Jun 12, 2023

  • Creates tools package to manually include linter + dependencies, forming a space to add any future build tools
  • Improve Makefile to avoid docker issues with linting
  • Add basic version check and warning to Makefile
  • Address protobuf generation config, which was complaining about versioning

Issues: linter known as Depsguard complains after these changes

Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
@pbukva pbukva changed the title Fix: address linting & protobuf issues fix: address linting & protobuf issues Jun 27, 2023
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
@@ -26,36 +26,52 @@ linters:
- unused

issues:
exclude:
- "directive `//nolint" # check up on this one here
Copy link
Member Author

@Jonathansumner Jonathansumner Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causes issues locally without these two lines

Signed-off-by: jonathansumner <jonathansumner98@gmail.com>
Copy link
Contributor

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (later we might need reevaluate all these disabled linters)

@Jonathansumner Jonathansumner merged commit 26432f8 into main Jun 27, 2023
@Jonathansumner Jonathansumner deleted the fix/improve-makefile branch June 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants