Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [WIP] Municipal Inflation determinism(map->list), cache redesign #159

Conversation

pbukva
Copy link
Contributor

@pbukva pbukva commented Jul 21, 2023

No description provided.

Jonathansumner
Jonathansumner previously approved these changes Jul 23, 2023
Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - nice touch with the caching improvements!

@pbukva pbukva dismissed Jonathansumner’s stale review July 25, 2023 15:16

The merge-base changed after approval.

@pbukva pbukva changed the base branch from main to feat/municipal-inflation July 25, 2023 15:17
Copy link
Member

@Jonathansumner Jonathansumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbukva pbukva merged commit df4d3c3 into fetchai:feat/municipal-inflation Jul 27, 2023
24 of 26 checks passed
pbukva added a commit that referenced this pull request Aug 12, 2023
* feat: Municipal Inflation MVP (#153)

* fix: Municipal Inflation: list->map & cli command printout (#154)

* fix: Municipal Inflation: grpc query error check (#155)

* fix: Municipal Inflation: cli tests for query with denom (#156)

* fix: [WIP] Municipal Inflation determinism(map->list), cache redesign (#159)

* [Cosmetic]: Municipal Inflation Cache: update code comment (#163)

* fix: [Cosmetic] Go linting (#164)

* fix: [Cosmetic] Go linting
* CI test run - setting golang v1.18.10

* fix: Municipal Inflation: protobuf yaml tag naming (#165)

* fix: Municipal Inflation: cache redesign atomic + simtest (#166)

* feat: Municipal Inflation: Handler optimisation & Validation fix (#167)

---------

Co-authored-by: void* <peter.bukva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants