Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic staking support #125

Merged
merged 6 commits into from
Mar 30, 2022
Merged

Basic staking support #125

merged 6 commits into from
Mar 30, 2022

Conversation

ejfitzgerald
Copy link
Member

This PR includes intial basic staking and distribution support for the Aerial API

@5A11
Copy link
Member

5A11 commented Mar 30, 2022

We should add docstring to aerial. This of course makes it easy to understand the code, but would also be an easy way of creating a reference API for cosmpy, which could essentially (with some changes) be the aerial docstrings.

Not suggesting we do it as part of this PR. Created issue #126.

@ejfitzgerald
Copy link
Member Author

Yep totally agree. Nice one on the issue

@ejfitzgerald ejfitzgerald requested a review from 5A11 March 30, 2022 10:58
@5A11 5A11 requested a review from daeMOn63 March 30, 2022 11:07
cosmpy/aerial/client/__init__.py Outdated Show resolved Hide resolved
cosmpy/aerial/client/__init__.py Outdated Show resolved Hide resolved
cosmpy/aerial/client/staking.py Show resolved Hide resolved
5A11 and others added 2 commits March 30, 2022 13:41
Co-authored-by: daeMOn <flavien.binet@gmail.com>
Copy link
Member

@5A11 5A11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@5A11 5A11 merged commit 6744e37 into develop Mar 30, 2022
@5A11 5A11 deleted the feature/aerial-staking branch March 30, 2022 15:43
5A11 added a commit that referenced this pull request Mar 30, 2022
* Aerial High Level API (#96)

* Aerial: Initial offline table based gas strategy (#107)

* gov module queries support (#91)

* gov api

* docstrings improved darglint check added to CI workflow

* Aerial: Simulation based Gas estimation (#108)

* added darglint support for flake8 (#109)

* unused darglint config removed from the setup.cfg (#111)

* unused darglint config removed from the setup.cfg

* darglint dedicated checks removed

* change remove pipfile.lock and test workflow

* revert intentional error

Co-authored-by: ali <ali.hosseini@fetch.ai>

* chores: update protos to cosmos v0.42.11, fix Makefile (#113)

* fix: recursive make commands invocations

recursive make commands should always use the variable MAKE
https://www.gnu.org/software/make/manual/html_node/MAKE-Variable.html#MAKE-Variable

* fix: lock python version

lock python version for `new_env` and `new_env_dev` Makefile targets

* chores: bump cosmos-sdk base version

* chores: regenerate proto files

* chores: gitignore proto generation workdirs

* add slashing module API (#116)

* added evidence module API (#117)

* fix: staking test_Validators assert (#119)

* feat: add params rest client (#120)

* feat: add params rest client, fix simulate call

* chores: lint

* Add distribution module (#92)

* Add distribution module

 * Create distribution rest client
 * Add tests for distribution module

* Remove unused import

* run black and isort

Signed-off-by: David Pierret <dapie@cros-nest.com>

* Update regexp to accept external modifications

Signed-off-by: David Pierret <dapie@cros-nest.com>

* remove not needed parameter

Signed-off-by: David Pierret <dapie@cros-nest.com>

* add slashes content in tests

Signed-off-by: David Pierret <dapie@cros-nest.com>

* Add a test on parameter values

Check the values are correctly encoded/decoded by the protobuf code.

Signed-off-by: David Pierret <dapie@cros-nest.com>

* chores: fix docstrings

Co-authored-by: David Pierret <dapie@cros-nest.com>
Co-authored-by: Flavien Binet <flavien.binet@gmail.com>

* Mint module (#122)

* Add Mint module

 * Create MintRestClient
 * Create Mint tests

* fix after check

Signed-off-by: David Pierret <dapie@cros-nest.com>

* Managment of the wrong value encoding

Some endpoints reply with strings when base64 encoded
values are expected.
The tests check that all the values are correct

Signed-off-by: David Pierret <dapie@cros-nest.com>

* fix lint issues

Signed-off-by: David Pierret <dapie@cros-nest.com>

* chores: fix docstrings

* chores: fix more docstrings

* pylint/mypy/linting fixes

Co-authored-by: David Pierret <dapie@cros-nest.com>
Co-authored-by: Flavien Binet <flavien.binet@gmail.com>
Co-authored-by: Galadrin <david.pierret@gmail.com>

* Initial documentation using MkDocs (#123)

* mkdocs setup and first few pages

* revert makefile dev python to 3.9; minor docs edit

* bump black version to 22.3

* delete extra files

* add deploy contract docs page

* Basic staking support (#125)

* feat: staking support for aerial

* docs: initial staking doc

* staking minor edits

* Update cosmpy/aerial/client/__init__.py

Co-authored-by: daeMOn <flavien.binet@gmail.com>

* chore: review comments

* chore: appeasing the style police

Co-authored-by: ali <ali.hosseini@fetch.ai>
Co-authored-by: daeMOn <flavien.binet@gmail.com>

* Minor docs edit (#129)

* minor edits

* cosmos sdk remove hyphen

* Feature/release 0.3.0 (#131)

* bump version in setup.py

* update history.md

Co-authored-by: Ed FitzGerald <edward.fitzgerald@fetch.ai>
Co-authored-by: Yuri Turchenkov <solarw.mail@gmail.com>
Co-authored-by: daeMOn <flavien.binet@gmail.com>
Co-authored-by: Galadrin <david.pierret@gmail.com>
Co-authored-by: David Pierret <dapie@cros-nest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants