-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): context stage 2 #363
Conversation
Sync messages and queries still need to be done but it works for most of the examples and should be ready for initial feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remaining subtleties to address, but overall this looks great.
Co-authored-by: James Riehl <33920192+jrriehl@users.noreply.github.com>
The raised issues are valid and will be revisited in the next iteration / a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
List of changes:
Dispenser
class in communication moduleagent.py
for message dispensingContext
interface / Abstract Base Class to be used by the handlersInternalContext
: for supporting pro-active behaviour (on_event, on_interval)ExternalContext
: for supporting re-active behaviour (on_message)