Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add timeout and retries to almanac api registration #505

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Aug 15, 2024

Proposed Changes

Adds short timeout and retries to almanac API registration to prevent this from blocking the agent in the case of service outage.

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

Copy link
Contributor

@Alejandro-Morales Alejandro-Morales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works fine!

@jrriehl jrriehl merged commit 84e18b3 into main Aug 15, 2024
9 checks passed
@jrriehl jrriehl deleted the fix/almanac-api-registration-timeout branch August 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants