fix(zerossl): concatenate response body as string instead of table #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @szesch ! |
fffonion
added a commit
to Kong/kong
that referenced
this pull request
Dec 6, 2022
<a name="0.10.1"></a> ## [0.10.1] - 2022-12-06 ### bug fixes - **zerossl:** concatenate response body as string instead of table ([#98](fffonion/lua-resty-acme#98)) [986b1db](fffonion/lua-resty-acme@986b1db) <a name="0.10.0"></a> ## [0.10.0] - 2022-11-18 ### features - **autossl:** expose function to get cert from LRU cache ([#96](fffonion/lua-resty-acme#96)) [6135d0e](fffonion/lua-resty-acme@6135d0e) - **autossl:** better cache handling in blocking mode [40f5d2d](fffonion/lua-resty-acme@40f5d2d) - **autossl:** fix behavior change in non blocking mode [aa484cc](fffonion/lua-resty-acme@aa484cc) - **autossl:** move chains set condition back inside the main loop [b83a535](fffonion/lua-resty-acme@b83a535) - **autossl:** add blocking mode [5a623a5](fffonion/lua-resty-acme@5a623a5)
flrgh
pushed a commit
to Kong/kong
that referenced
this pull request
Dec 8, 2022
<a name="0.10.1"></a> ## [0.10.1] - 2022-12-06 ### bug fixes - **zerossl:** concatenate response body as string instead of table ([#98](fffonion/lua-resty-acme#98)) [986b1db](fffonion/lua-resty-acme@986b1db) <a name="0.10.0"></a> ## [0.10.0] - 2022-11-18 ### features - **autossl:** expose function to get cert from LRU cache ([#96](fffonion/lua-resty-acme#96)) [6135d0e](fffonion/lua-resty-acme@6135d0e) - **autossl:** better cache handling in blocking mode [40f5d2d](fffonion/lua-resty-acme@40f5d2d) - **autossl:** fix behavior change in non blocking mode [aa484cc](fffonion/lua-resty-acme@aa484cc) - **autossl:** move chains set condition back inside the main loop [b83a535](fffonion/lua-resty-acme@b83a535) - **autossl:** add blocking mode [5a623a5](fffonion/lua-resty-acme@5a623a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some error messages in the Kong logs
lua entry thread aborted: runtime error: /usr/local/share/lua/5.1/resty/acme/eab/zerossl-com.lua:24: attempt to concatenate local 'body' (a table value)bodyis a table which was causing the issue so I updated the error messages to useresp.body(string) instead.@fffonion