Merge pull request #203 from dynastyprocess/mflstarters-fix

fix mfl starters bugs

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: ffscrapr
 Title: API Client for Fantasy Football League Platforms
-Version: 1.2.2.12
+Version: 1.2.2.13
 Authors@R: 
     c(person(given = "Tan",
            family = "Ho",

NEWS.md

@@ -21,6 +21,7 @@
 - Fixed bug in MFL's `ff_playerscores()` function so that it correctly pulls older names. (#196, thanks for reporting Mike!) (v1.2.2.11)
 - Actually export `dp_cleannames()` and add it to the NAMESPACE so it's accessible to the end user, whoops.
 - Refactored all tests to move test cache files to a separate/non-package location (https://github.com/dynastyprocess/ffscrapr-tests) - so that it is not included in CRAN's package sizing (v1.2.2.12)
+- Fixed bugs in MFL's `ff_starters()` function - bad default arg
 
 
 # ffscrapr 1.2.2

R/espn_league.R

@@ -6,10 +6,7 @@
 #'
 #' @examples
 #' \donttest{
-#' conn <- espn_connect(
-#'   season = 2020,
-#'   league_id = 899513
-#' )
+#' conn <- espn_connect(season = 2020, league_id = 899513)
 #' ff_league(conn)
 #' }
 #'

R/mfl_starters.R

@@ -12,17 +12,17 @@
 #' @examples
 #' \donttest{
 #' dlf_conn <- mfl_connect(2020, league_id = 37920)
-#' ff_starters(conn = dlf_conn, week = 1:2)
+#' ff_starters(conn = dlf_conn)
 #' }
 #'
 #' @export
-ff_starters.mfl_conn <- function(conn, week = "all", season = NULL, ...) {
+ff_starters.mfl_conn <- function(conn, week = 1:17, season = NULL, ...) {
   if (is.null(season)) season <- conn$season
 
-  checkmate::assert_numeric(week, lower = 1, upper = 21)
+  checkmate::assert_number(week, lower = 1, upper = 21)
   checkmate::assert_number(season)
 
-  players_endpoint <- sleeper_players() %>%
+  players_endpoint <- mfl_players() %>%
     dplyr::select("player_id", "player_name", "pos", "team")
 
   franchises_endpoint <- ff_franchises(conn) %>%