Refactoring of LBManager.nextFreeSocket #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
reviewed
Feb 26, 2021
| isOccupied := make([]bool, int(m.PortRangeSize)) | ||
| // If there are already any managed services, store all the used ports in a slice. | ||
| // Also store the LoadBalancerIP. | ||
| portsInUse := make([]int32, len(lbs.Items)) | ||
| for i := range lbs.Items { |
There was a problem hiding this comment.
What about factoring this logic out into a testable function ?
…ctor-nextFreeSocket
eberlep
commented
Apr 6, 2021
There was a problem hiding this comment.
I think that is not exactly what @majst01 had in mind, but it also works.
Stefan probably meant refactoring the logic so it is easily testable without any additional dependencies. At the end of the day, the core task of this code is to simply pick the next free int from a given range with another list of occupied ints not to choose. When refactored correctly, we do not need any mocks to test this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.