Skip to content

Change maintenance to string #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

Change maintenance to string #147

merged 1 commit into from
Mar 3, 2021

Conversation

LimKianAn
Copy link
Contributor

Solve issue #100.

@LimKianAn LimKianAn requested a review from eberlep March 2, 2021 15:20
@LimKianAn LimKianAn mentioned this pull request Mar 2, 2021
Closed
eberlep
eberlep approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@eberlep eberlep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

a) it works
b) that string will be filled by our code (the cloud-api) anyway

@eberlep eberlep merged commit 68e9a17 into main Mar 3, 2021
@eberlep eberlep deleted the change-maintenance-to-string branch March 3, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eberlep eberlep eberlep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LimKianAn @eberlep