Skip to content

Do not record event when a watched postgres can not be found #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions controllers/postgres_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,16 @@ type PostgresReconciler struct {
func (r *PostgresReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
log := r.Log.WithValues("postgres", req.NamespacedName)

log.Info("fetchting postgres")
log.Info("reconciling")
instance := &pg.Postgres{}
if err := r.Get(ctx, req.NamespacedName, instance); err != nil {
if errors.IsNotFound(err) {
// the instance was updated, but does not exist anymore -> do nothing, it was probably deleted
return ctrl.Result{}, nil
}

r.recorder.Eventf(instance, "Warning", "Error", "failed to get resource: %v", err)
return ctrl.Result{}, client.IgnoreNotFound(err)
return ctrl.Result{}, err
}
log.Info("postgres fetched", "postgres", instance)

Expand Down