Allow Any Postgres Params

[eberlep]

No description provided.

[eberlep]

Overwriting of default params works as well:

Test (Control Plane):

 spec:
   postgresParams:
     pgaudit.log: all, -misc
     pgaudit.log_parameter: "off"

Result (Service Cluster):

 spec:
   postgresql:
     parameters:
       pgaudit.log: all, -misc
       pgaudit.log_catalog: "off"
       pgaudit.log_parameter: "off"
       pgaudit.log_relation: "on"
       shared_buffers: 64MB
       shared_preload_libraries: pgaudit

Default (Service Cluster):

 spec:
   postgresql:
     parameters:
       pgaudit.log: ddl
       pgaudit.log_catalog: "off"
       pgaudit.log_parameter: "on"
       pgaudit.log_relation: "on"
       shared_buffers: 64MB
       shared_preload_libraries: pgaudit

[eberlep]

Setting numeric values as strings seems to work as well:

Test (Control Plane):

 spec:
   postgresParams:
     max_connections: "1001"

Result (Service Cluster):

 spec:
   postgresql:
     parameters:
       max_connections: "1001"

Result (Patroni):

root@pgsampletenant-complete-0:/home/postgres# patronictl show-config
[..]
postgresql:
  parameters:
    [..]
    max_connections: '1001'
    [..]

Result (Database Instance):

postgres=# SHOW max_connections;
 max_connections 
-----------------
 1001
(1 row)

[majst01]

My feeling is that there should be at least be a denylist of params be configurable which a user cannot override

[eberlep]

In the central cloud-api or locally in each postgreslet/service cluster? Locally is more flexible, but also more difficult to maintain.

[majst01]

unsure about this

[majst01]

implementation wise, locally in a configmap is easier, deployment is done via playbook, so keeping this configmap identical between installation should also be a easy task

[eberlep]

I used viper to read a (apparently space-separated) list of blocked values from the environment, convert it into a map for easier use and pass that map along to the code in question. now before setting a given postgres param, we check if is contained in the blocklist. if it is, we simply ignore it.

[majst01]

parameters which are not allowed to change should be considered, at least in a slice in the configmap