Postgres Restore #306
Merged
Postgres Restore #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crd (and also switch to backup secrets!)
eberlep
commented
Dec 15, 2021
api/v1/postgres_types.go
Outdated
| @@ -195,7 +207,8 @@ type PostgresStatus struct { | |||
|
|
|||
| Socket Socket `json:"socket,omitempty"` | |||
|
|
|||
| ChildName string `json:"childName,omitempty"` | |||
| ChildName string `json:"childName,omitempty"` | |||
| ChildInternalID string `json:"childInternalID,omitempty"` | |||
There was a problem hiding this comment.
Remove, not needed
| } | ||
|
|
||
| z.Spec.Clone = &zalando.CloneDescription{ | ||
| ClusterName: srcDB.ToPeripheralResourceName(), |
There was a problem hiding this comment.
add nil check for srcDB
config/samples/clone.yaml
Outdated
| @@ -0,0 +1,30 @@ | |||
| apiVersion: database.fits.cloud/v1 | |||
| @@ -85,7 +86,20 @@ func (r *StatusReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| // update the status of the remote object | |||
| owner.Status.Description = instance.Status.PostgresClusterStatus | |||
| // update the reference to the zalando instance in the remote object | |||
| owner.Status.ChildName = instance.Name | |||
| owner.Status.ChildName = instance.ObjectMeta.Name | |||
There was a problem hiding this comment.
The comment is in the wrong line, I removed the ChildInternalID code.
majst01
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.