Skip to content

Support for Default Postgres Params #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2022

Conversation

eberlep
Copy link
Collaborator

@eberlep eberlep commented Mar 18, 2022

⚠️ Introduce default Postgres Params -> triggers rolling update of running databases

@eberlep eberlep linked an issue Mar 18, 2022 that may be closed by this pull request
@eberlep eberlep linked an issue May 12, 2022 that may be closed by this pull request
@eberlep eberlep linked an issue May 12, 2022 that may be closed by this pull request
@eberlep eberlep marked this pull request as ready for review May 12, 2022 18:02
@eberlep
Copy link
Collaborator Author

eberlep commented May 12, 2022

Patroni:

 $ k exec -c postgres pgfits-defaultparams9365a4d-0  -- grep -E "tcp_keepalives_idle|tcp_keepalives_interval|ssl_min_protocol_version|ssl_prefer_server_ciphers|ssl_ciphers|log_file_mode" postgres.yml
        ssl_ciphers: ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384
        ssl_min_protocol_version: TLSv1.2
        ssl_prefer_server_ciphers: 'on'
        tcp_keepalives_idle: '200'
        tcp_keepalives_interval: '30'
    log_file_mode: '0600'

Postgres:

 $ k exec -c postgres pgfits-defaultparams9365a4d-0  -- grep -E "tcp_keepalives_idle|tcp_keepalives_interval|ssl_min_protocol_version|ssl_prefer_server_ciphers|ssl_ciphers|log_file_mode" /home/postgres/pgdata/pgroot/data/postgresql.conf
log_file_mode = '0600'
ssl_ciphers = 'ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384'
ssl_min_protocol_version = 'TLSv1.2'
ssl_prefer_server_ciphers = 'on'
tcp_keepalives_idle = '200'
tcp_keepalives_interval = '30'

Override (does not seem to affect the postgres.yml):

 $ k exec -c postgres pgfits-defaultparams9365a4d-0  -- patronictl show-config | grep tcp_keepalives_idle
    tcp_keepalives_idle: '234'
 $ k exec -c postgres pgfits-defaultparams9365a4d-0  -- grep -E "tcp_keepalives_idle" /home/postgres/pgdata/pgroot/data/postgresql.conf
tcp_keepalives_idle = '234'

@eberlep eberlep requested a review from majst01 May 12, 2022 18:12
@eberlep eberlep merged commit 29ff9fd into main May 13, 2022
@eberlep eberlep deleted the 345-set-default-tcp_keepalives-in-postgres-instance branch July 15, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set default tcp_keepalives in postgres-instance Introduce Default Postgres Params per Postgreslet Make KeepAlive Configurable
1 participant