Skip to content

Try different configuration for S3 SSE-C #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 14, 2023
Merged

Try different configuration for S3 SSE-C #363

merged 20 commits into from
Mar 14, 2023

Conversation

eberlep
Copy link
Collaborator

@eberlep eberlep commented May 6, 2022

No description provided.

@eberlep eberlep requested a review from Gerrit91 January 26, 2023 07:33
@eberlep eberlep marked this pull request as ready for review February 16, 2023 08:12
Gerrit91
Gerrit91 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@Gerrit91 Gerrit91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would suggest introducing a validation webhook for the postgreslet that prevents some operations when acting on the CRDs, e.g. making the update of the s3 encryption key immutable for as long as this is not supported.

@eberlep eberlep merged commit 47f7748 into main Mar 14, 2023
@eberlep eberlep deleted the walg_s3_sse branch March 14, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gerrit91 Gerrit91 Gerrit91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eberlep @Gerrit91