Fix postgrelet pod failure #50
Conversation
| @@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1beta1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.2.5 | |||
| controller-gen.kubebuilder.io/version: v0.3.0 | |||
There was a problem hiding this comment.
Which version are we actually using? I have v0.2.5 locally, hence I commited a version of this file generated by the older version. IIRC, the Makefile references v0.2.5?
There was a problem hiding this comment.
You are right. We stick with what kubebuilder recommends.
| @@ -46,7 +46,17 @@ The following steps will create a _Secret_ called `postgreslet`, and add all fil | |||
| As we only copy one file, the secret will contain only one key named `controlplane-kubeconfig` which will contain the control plane kube config. | |||
|
|
|||
| ```sh | |||
| make docker-build | |||
| make kind-load-image | |||
There was a problem hiding this comment.
Can we add docker-build as a dependency to the kind-load-image target in the Makefile?
| @@ -24,6 +23,7 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o manager | |||
| FROM gcr.io/distroless/static:nonroot | |||
| WORKDIR / | |||
| COPY --from=builder /workspace/manager . | |||
| COPY external.yaml external.yaml | |||
There was a problem hiding this comment.
Just a thought: Can we maybe rename that file? Something like operator.yaml? I am also tinking about using a subfolder?
So maybe... external/operator.yaml?
There was a problem hiding this comment.
Agreed! I will change that in #35 since we have svc-postgres-operator.yaml and crd-postgresql.yaml in that branch. What do you say?
| @@ -4,5 +4,5 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
| kind: Kustomization | |||
| images: | |||
| - name: controller | |||
| newName: postgres-controller | |||
| newName: r.metal-stack.io/extensions/postgreslet | |||
There was a problem hiding this comment.
This is technically unrelated to this issue and should be a separate PR?
There was a problem hiding this comment.
Sorry! This was generated by make deploy.
| @@ -21,5 +21,6 @@ spec: | |||
| name: https | |||
| - name: manager | |||
| args: | |||
| - "--metrics-addr=127.0.0.1:8080" | |||
Please follow the steps in
README.md.