Skip to content

Reconciler with old controller gen #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Nov 30, 2020
Merged

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Nov 30, 2020

No description provided.

Makefile Outdated
@@ -42,7 +42,7 @@ deploy: manifests
# todo: Remove `sed ...` once the bug in `kubebuilder` is fixed
manifests: controller-gen
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
sed -z 's#spec:#spec:\n preserveUnknownFields: false#' -i config/crd/bases/database.fits.cloud_postgres.yaml
# sed -z 's#spec:#spec:\n preserveUnknownFields: false#' -i config/crd/bases/database.fits.cloud_postgres.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

)

// Requeue defines in how many seconds a requeue should happen
var Requeue = ctrl.Result{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexport

@majst01 majst01 merged commit bba44e3 into main Nov 30, 2020
@majst01 majst01 deleted the reconciler-with-old-controller-gen branch November 30, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants