70 load balancer #86
Merged
70 load balancer #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denying all access is default
|
LGTM |
majst01
reviewed
Feb 12, 2021
api/v1/postgres_types.go
Outdated
| @@ -136,6 +138,14 @@ type PostgresStatus struct { | |||
| // INSERT ADDITIONAL STATUS FIELD - define observed state of cluster | |||
| // Important: Run "make" to regenerate code after modifying this file | |||
| Description string `json:"description,omitempty"` | |||
|
|
|||
| LBSocket LBSocket `json:"lbSocket,omitempty"` | |||
There was a problem hiding this comment.
I would prefer Socket instead of LBSocket
eberlep
requested changes
Feb 15, 2021
charts/postgreslet/values.yaml
Outdated
| # loadBalancerIP defines the load-balancer IP of postgres in this cluster | ||
| loadBalancerIP: "172.0.0.1" | ||
| # portRangeStart deinfes the start of the port range of services LoadBalancer | ||
| portRangeStart: 31767 |
There was a problem hiding this comment.
Which ports to use as defaults?
There was a problem hiding this comment.
@majst01 what do you think?
| @@ -115,6 +115,20 @@ func (m *OperatorManager) IsOperatorDeletable(ctx context.Context, namespace str | |||
| m.Log.Info("operator is deletable") | |||
| return true, nil | |||
| } | |||
|
|
|||
eberlep
reviewed
Feb 15, 2021
eberlep
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service LoadBalanceris created/deleted alongsidePostgres.Endpointsare correctly picked up through the labels.nextFreePort()in lbmanager.go works.@majst01 @eberlep Please comment if the direction is correct.