Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make commands atomic #164

Merged
merged 47 commits into from
Dec 24, 2019
Merged

Make commands atomic #164

merged 47 commits into from
Dec 24, 2019

Conversation

stdevAlDen
Copy link
Contributor

@stdevAlDen stdevAlDen commented Dec 18, 2019 •
edited
Loading

Fixes #163

Changes:

  • Add Sequencer as a Devicer implementation that forces all commands to be atomic.

Does this change need to mentioned in CHANGELOG.md?
yes

Requires changes in protobuf specs?
no
related to PR fibercrypto/fibercryptowallet#253

Requires testing
yes

TODO:

@stdevAlDen stdevAlDen added the enhancement New feature or request label Dec 18, 2019
@stdevAlDen stdevAlDen added this to the 1.0.0 milestone Dec 18, 2019
@stdevAlDen stdevAlDen self-assigned this Dec 18, 2019
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t163_make_commands_atomic branch from ad3aeef to 6b79a97 Compare December 18, 2019 23:17
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t163_make_commands_atomic branch 3 times, most recently from b65f190 to efd1ba1 Compare December 19, 2019 00:12
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t163_make_commands_atomic branch from efd1ba1 to 45c91ca Compare December 19, 2019 00:20
Alvaro Denis added 14 commits December 19, 2019 20:36
use ChangePin workflow from Sequencer ref fibercrypto#163
e56e4ba
fix apply settings ref fibercrypto#163
e20865b
fix features ref fibercrypto#163
66224bc
fix address gen ref fibercrypto#163
35d63f3
use Recovery workflow from Sequencer ref fibercrypto#163
437db62
use Generate Mnemonic workflow from Sequencer ref fibercrypto#163
545a71c
use Transactio Mnemonic workflow from Sequencer ref fibercrypto#163
a561e89
use Sign Message workflow from Sequencer ref fibercrypto#163
63cfb1a
use Wipe workflow from Sequencer ref fibercrypto#163
e8315ec
use Set Mnemonic workflow from Sequencer ref fibercrypto#163
7bf9754
refactor handling of final response in a reusable function ref fiberc…
8c209d1 
…rypto#163
do not force button ack to have a final response in handleInputIntera…
e881ac8 
…ction ref fibercrypto#163
refactor, make the command first response a reusable function ref fib…
5e1bf6c 
…ercrypto#163
cli: move device initialization to a reusable function ref fibercrypt…
27c2b73 
…o#163
@stdevAlDen stdevAlDen force-pushed the stdevAlDen_t163_make_commands_atomic branch from 130be72 to 27c2b73 Compare December 21, 2019 00:22
@stdevAlDen stdevAlDen changed the title [WIP]Make commands atomic Make commands atomic Dec 24, 2019
@olemis olemis mentioned this pull request Dec 24, 2019
Closed
@olemis olemis merged commit 0688a8e into fibercrypto:develop Dec 24, 2019
@olemis olemis mentioned this pull request Dec 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis olemis approved these changes

Assignees

@stdevAlDen stdevAlDen

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stdevAlDen @olemis