Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yandex.es6:22-24: Implement tracking of certain actions... #434

Closed
0pdd opened this issue Jul 20, 2018 · 1 comment
Closed

yandex.es6:22-24: Implement tracking of certain actions... #434

0pdd opened this issue Jul 20, 2018 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 20, 2018

The puzzle 129-385e3122 from #129 has to be resolved:

shopelectro/front/js/shared/yandex.es6

Lines 22 to 24 in 1a5a51c

// @todo #129 Implement tracking of certain actions on front-end for YA and GA.
// Actions: one-click purchase, changing products count on the order page.
// See the parent issue for a detail.

The puzzle was created by Artemiy on 20-Jul-18.

Estimate: 0 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 20, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 20, 2018
@ArtemijRodionov
rf#129 ecommerce trackers (#416)
1a5a51c 
* Implement yaTracker

* Remove redundant expressions.

* Implement tracking for gaTracker

* WIP

* Fix tracking

* Undo docker changes

* Review fixes

* Review fixes

* Fix nodejs's Dockerfile

* Try to fix tests

* Try to fix CI's npm

* Try to use fidals/se-nodejs:dev for CI's npm pipe

* Bump refarm version

* Remove js rest/spread plugin

* Update js error log.

* Swap args for gaTracker.purchase(...)

* Update robots url because of new refarm version

* Unskip test_robots

* Undo DELETE_PRODUCT goal

* Apply linter rules
@0pdd 0pdd mentioned this issue Jul 20, 2018
Merged
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi take it any teammate can take this issue and start working with it front markup or work with js labels Jul 20, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Jul 26, 2018
@ArtemijRodionov ArtemijRodionov mentioned this issue Jul 27, 2018
Merged
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jul 31, 2018
0pdd referenced this issue Jul 31, 2018
@ArtemijRodionov
Implement rest of js tracking actions (#455)
10514ec 
* Implement js tracking action: one-click buy, clearing of cart, changing product numbers

* Self-review fixes

* Fix onOneClickbuy ecommerce target
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jul 31, 2018
duker33 added a commit that referenced this issue Feb 14, 2019
@duker33
#434 Grade refarm dep to 0.4.31
323c4bf
duker33 added a commit that referenced this issue Feb 14, 2019
@duker33
#434 Grade refarm dep to 0.4.31
f3aa4ee
duker33 added a commit that referenced this issue Feb 14, 2019
@duker33
#699 #723 Category context, Category request data (#726)
1bb0374 
* #723  Pack request args to class in for CategoryPage and load_more views

* #699  Create CatalogContext class

* #699  Create separated context for list params

* #699  Move all work with DB to context side

* #699  Move RequestData and Context classes to relevant modules

* #fix  Tag refarm-site dep on branch

* #fix  Apply CI rules

* #699  Review minor fixes

* #699  Review #1. Move CatalogContext to context module

* #fix  Tag catalog tests

* #723  Review #1. Raise exception from LoadMore

* #699  Redefine ListParams context class

* #699  Merge Catalog and ListParams classes

* rf#255  Move some products context to the qs

* #434  Grade refarm dep to 0.4.31

* #699  Merge fixes

* #699  Adapt cart to the new interface

* #699  Add fast test for index page images

* #699  Fix index sitemap

* #fix  Grade refarm dep to 0.4.32

* #699  Adapt cart to new positions interface

* #699  Adapt cart #2

* #699  Adapt cart #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd