Fix issue33 #43
Merged
Fix issue33 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
put the Ch1_ or Ch2_ text prefic in front of the image channel name to the user know which is which. I notice again the method in question has three versions, which share much code, and should be thus refactored to prevent copy paste bugs... i had to do the same things 3x here. Signed-off-by: daniel j. white <dan@chalkie.org.uk>
Signed-off-by: daniel j. white <dan@chalkie.org.uk>
User output now contains the type of mask used or not and the mask ID as results values Signed-off-by: daniel j. white <dan@chalkie.org.uk>
because, after Toms earlier commit, we can use strings as results values too. Signed-off-by: daniel j. white <dan@chalkie.org.uk>
|
@tomka ok to merge? |
|
Sorry for the delay, was sick the last week, but will have a look at it today. |
|
Indeed, the |
|
Me too.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #33 and also augments the results output which get unique roi/mask IDs for each coloc job that is run, and remove the frightening -1 result value and change to Done.