concat ASI and non ASI libraries

[staabm]

when concatenating js files which use Automatic Semicolon Insertion with other which doesn't use ASI syntax errors may occur.

I could fix those errors, just by adding a ";" between the concatenated files.

    $contents .= $newcontents;
    if( $ftype === "js" ){
                // add a extra semicolon, so ASI and non-ASI js-files while not clash
        $contents .= ';';
    }

The console shows erorrs like TypeError: (intermediate value)(...) is not a function, which do not appear when loading the files using separate <scritpt> tags

[jefflembeck]

I'd really prefer not adding something like this. Quickconcat has the purpose of concatenating your files, but it doesn't edit them.

@scottjehl , what do you think?

[scottjehl]

I don't have a strong opinion, but I think this is fairly common in JS concatenation scripts.

I'd support the addition if others think it's valuable.

On Oct 29, 2012, at 5:51 PM, Jeff Lembeck wrote:

I'd really prefer not adding something like this. Quickconcat has the purpose of concatenating your files, but it doesn't edit them.

@scottjehl , what do you think?

—
Reply to this email directly or view it on GitHub.

[jefflembeck]

Ah, if it's common (and therefore expected), then I'm cool with it.

[scottjehl]

We already muck with file paths anyway, so I wouldn't say we're very hands-off with contents to begin with.

On Oct 29, 2012, at 6:02 PM, Jeff Lembeck wrote:

Ah, if it's common (and therefore expected), then I'm cool with it.

—
Reply to this email directly or view it on GitHub.

[staabm]

I also think it's a common case that some do ASI and some not..
e.g. github uses ASI -> https://github.com/defunkt/jquery-pjax
while jQuery doesn't.

if we go in this direction, maybe we should rewrite the util in a more object oriented way so we will not mix up all the filetype specific stuff...

if so, in the git repos we should have one class per file and utilize a build mechanism which produces the 1-file util we have today..

[jefflembeck]

Let's split this into two issues. One to address the ASI/non-ASI problem and the other to discuss how the util is written. It's a pretty big change and would require tests all along the way.

[staabm]

Great, thanks! 👍