-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imba icon #664
Comments
References: file-icons/atom#664
We have a dedicated repository where new icon requests can be submitted. I've already added an SVG for it in
Well... there is. The package's file-to-icon mappings are handled in |
Thank you for adding it!
I wasn't aware of this, how is it that picks up every other language's file types? Are all the other file types I work with just supported/recognized by Atom per default? |
Nope, we manually declare the scope in the config file itself. See the documentation at the top of the file:
However, the config also supports a shorthand. E.g., this line: ANTLR:
icon: "antlr"
match: [
[".g", "medium-red", "antlr"]
] ... expands into this at compile-time: ANTLR:
icon: "antlr"
match: [
[".g", "medium-red", alias: "antlr", interpreter: "antlr", scope: "antlr"]
] In most cases, all three properties are identical, so the shorthand is sufficient for most cases. It's becoming increasingly tempting to move the icon-config logic to a separate repository... |
Ahhh yeah, I feel like a moron, I was browsing the commit changes just now and saw the File Icons package config.cson and that you manually defined everything there, and had added an entry for the Imba file type. Came back to strike out my comment and amend that I'm an idiot but you beat me to it. You're on top of things!
I saw that discussion while trying to figure out how to implement the Icon without using LESS. I would advocate for it, just due to extensibility purposes honestly. |
Edited |
Hey, I was just curious whether or not you guys could add the Imba icon, a compile-to-JS language.
See:
https://github.com/somebee/imba
https://atom.io/packages/language-imba
I'm currently doing it right now through LESS in the stylesheet, feels really hacky. The language-imba package declares:
But yet despite this, the grammar being properly autodetected, and using a custom language definition in Atom's config coffeescript, I couldn't get the CSS selector to trigger. I don't think I should even need to declare it a custom file type because of the Scope and File Type from the language package, but I tried anways
Still just get:
So using this:
Unfortunately the SVG doesn't scale well at small dimensions, but what can you do?
Thank you guys!
The text was updated successfully, but these errors were encountered: