fix: bug bypassing basic filters

[LexLuthr]

Basic filters are now working as expected.

Online = false and offline = true

online = true and offline = false

[dirkmc]

Can you explain the change here?
I don't understand why we would make the call to get deal filter params if the StorageFilter is not set?

[LexLuthr]

So, it would seem we still need to call the BasicDealFilter() even when external deal filter is not set. The removed part of the code skipped that section and basic deal filter was not running. Once BasicDealFilter() completes the checks like we have enough storage, funds etc on SP side, then it runs "cmd" filter.

[dirkmc]

Ok that makes sense, thanks 👍

In that case I would change the code in getDealFilterParams so that if the storage filter is not set, it doesn't get the funds or storage status either.

In other words at the top of getDealFilterParams:

if p.config.StorageFilter == "" {
	return &dealfilter.DealFilterParams{
                FundsState: <zero value for funds status>,
                StorageState: <zero value for storage state> ,
        }
}

Please also add a comment to the code explaining what you said in your github comment above.

[LexLuthr]

Updated the logic as per suggestion. Tested on devnet, working as expected.

[dirkmc]

Nice work 🙌