tracing behind feature-flag for boostd; configuration in config.toml #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
commented
Sep 8, 2022
| - LOTUS_API_LISTENADDRESS=/dns/boost/tcp/1288/http | ||
| - LOTUS_PATH=/var/lib/lotus | ||
| - LOTUS_MINER_PATH=/var/lib/lotus-miner | ||
| - LOTUS_TRACING_ENABLED=true |
There was a problem hiding this comment.
We should rename this from LOTUS to BOOST at some point.
nonsense
changed the title
dirkmc
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the
[Tracing]configuration section in the Boost node config.tomlIt also moves the instantiation of the tracing system within the Boost node dependency injection.
It is also renaming the flag on
booster-httpfrom--enable-tracingto just--tracing, and adds--tracing-endpoint.