IPFS block service refactor #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-gor
approved these changes
Feb 18, 2020
turuslan
approved these changes
Feb 18, 2020
sergkaprovich
force-pushed
the
feature/blockservice-interface
branch
from
ed23857 to
9d91359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Discovered, that several recently implemented components uses
IpfsDatastoreinterface insteadBlockService.It's better to use
IpfsDatastoreinterface in the IPFS block service implementation.Benefits
More flexible and logical design, refactor one component instead of many.
Possible Drawbacks
None