Skip to content

paych maker #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021
Merged

paych maker #496

merged 1 commit into from
Nov 3, 2021

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Nov 2, 2021

  • extract PaychGet from PaymentChannelManager into PaychMaker.

  • prevent duplicate channels with same from-to.

  • batch pending PaychGet to single message.

  • sending one message at a time and waiting before sending next.

  • save relevant info to db.

  • fix StateWaitMsg lock.

  • may rename, e.g. ~router.

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #496 (5e3b40c) into master (6023790) will decrease coverage by 0.20%.
The diff coverage is 1.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   46.19%   45.99%   -0.21%     
==========================================
  Files         669      672       +3     
  Lines       29694    29828     +134     
  Branches    16412    16496      +84     
==========================================
  Hits        13718    13718              
- Misses      12042    12176     +134     
  Partials     3934     3934              
Impacted Files Coverage Δ
core/api/impl/paych_get.hpp 0.00% <0.00%> (ø)
core/node/main/builder.cpp 1.55% <0.00%> (-0.02%) ⬇️
core/payment_channel_manager/impl/maker.cpp 0.00% <0.00%> (ø)
core/payment_channel_manager/impl/maker.hpp 0.00% <0.00%> (ø)
...nnel_manager/impl/payment_channel_manager_impl.cpp 0.00% <ø> (ø)
...ayment_channel_manager/payment_channel_manager.hpp 0.00% <ø> (ø)
core/storage/chain/msg_waiter.cpp 0.00% <0.00%> (ø)
core/storage/leveldb/prefix.hpp 66.66% <ø> (ø)
core/storage/leveldb/prefix.cpp 14.63% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6023790...5e3b40c. Read the comment docs.

@turuslan turuslan merged commit 6f2fb80 into master Nov 3, 2021
@turuslan turuslan deleted the paych_get branch November 3, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants