Skip to content

Conversation

Alexey-N-Chernyshov
Copy link
Contributor

Signed-off-by: Alexey Chernyshov alexey.n.chernyshov@gmail.com

Description of the Change

Banch of clang-tidy warning is fixed. No logic changed.

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Signed-off-by: Alexey Chernyshov <alexey.n.chernyshov@gmail.com>
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #553 (ff558a8) into master (365a7c3) will increase coverage by 0.04%.
The diff coverage is 66.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
+ Coverage   46.80%   46.84%   +0.04%     
==========================================
  Files         677      680       +3     
  Lines       30682    30690       +8     
  Branches    17055    17059       +4     
==========================================
+ Hits        14360    14378      +18     
+ Misses      12088    12077      -11     
- Partials     4234     4235       +1     
Impacted Files Coverage Δ
core/codec/cbor/light_reader/state_tree.hpp 35.29% <0.00%> (-2.21%) ⬇️
core/common/outcome_fmt.hpp 0.00% <0.00%> (ø)
core/storage/car/cids_index/cids_index.hpp 90.00% <ø> (ø)
core/storage/car/cids_index/util.hpp 30.39% <0.00%> (ø)
core/storage/chain/msg_waiter.cpp 0.00% <0.00%> (ø)
...fs/api_ipfs_datastore/api_ipfs_datastore_error.cpp 0.00% <0.00%> (ø)
...hsync/impl/network/marshalling/message_builder.hpp 100.00% <ø> (ø)
core/storage/ipfs/impl/ipfs_datastore_error.cpp 25.00% <0.00%> (+8.33%) ⬆️
core/storage/keystore/keystore.hpp 100.00% <ø> (ø)
core/storage/map_prefix/prefix.cpp 14.45% <0.00%> (-0.18%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365a7c3...ff558a8. Read the comment docs.

@Alexey-N-Chernyshov Alexey-N-Chernyshov merged commit 65190ea into master Dec 17, 2021
@Alexey-N-Chernyshov Alexey-N-Chernyshov deleted the feature/clang-tidy-fixes branch December 17, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants