Skip to content

Conversation

turuslan
Copy link
Contributor

Description of the Change

Add VMExitCode.
Add Invoker that invokes builtin actor code.
Refactor CronActor.

Benefits

Invoking builtin actor code.

Possible Drawbacks

None

Copy link
Contributor

@masterjedy masterjedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain what are that magic numbers 1, 254, 255 as VMExitCode?
It looks like a hack. Can't you use real enum constants?

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan force-pushed the feature/code-loading branch from 07aaa85 to c5744c0 Compare January 13, 2020 17:41
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from masterjedy January 14, 2020 09:12
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit e8b69b6 into master Jan 14, 2020
@turuslan turuslan deleted the feature/code-loading branch January 14, 2020 15:27
igor-egorov pushed a commit to igor-egorov/cpp-filecoin that referenced this pull request Mar 30, 2020
Signed-off-by: artyom-yurin <artem_yrin@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants