Reward Actor and Reward Actor State #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 12, 2020 14:18
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp> # Conflicts: # core/vm/actor/builtin/CMakeLists.txt # core/vm/exit_code/impl/exit_code.cpp
|
There is build error on Ubuntu. |
added 3 commits
February 13, 2020 13:51
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp> # Conflicts: # core/primitives/big_int.hpp
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
turuslan
approved these changes
Feb 13, 2020
Alexey-N-Chernyshov
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Egorov igor@soramitsu.co.jp
Description of the Change
Reward actor and its state are implemented.
Possible Drawbacks
Error-prone arithmetic around BigInt and UBigInt.
Lacks CBOR tests.
Usage Examples or Tests [optional]
To be done as soon as the reference golang impl gets done.