FVM: Simplify Randomness externs, perform hashing on the Rust side #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
arajasek
force-pushed
the
asr/randomness
branch
from
599ecd9 to
a6160f9
Compare
Stebalien
approved these changes
Dec 20, 2022
| } | ||
| } | ||
|
|
||
| fn draw_randomness( |
There was a problem hiding this comment.
Can we have one or two "fixture" tests? I.e.:
- In lotus, explicitly generate some randomness (e.g., with a unit test).
- Hard-code those in a test in this file, and make sure this function generates the same outputs.
|
Closing, stale |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor intended to ultimately move the hashing portion of the randomness calculation into the FVM itself.