Skip to content

Conversation

fridrik01
Copy link
Contributor

@fridrik01 fridrik01 commented Jul 27, 2023

Related: filecoin-project/ref-fvm#1793 and https://github.com/filecoin-project/fvm-pm/issues/613

Relevant PR in ref-fvm: filecoin-project/ref-fvm#1823
Relevant PR in Lotus: filecoin-project/lotus#11100

This PR updates the rust bindings to include the new fields introduced in filecoin-project/ref-fvm#1823.

Will rebase and update PR once filecoin-project/ref-fvm#1823 lands which should address CI errors.

@fridrik01 fridrik01 force-pushed the traceapi-new-fields branch from 6f9cb41 to e1ed027 Compare July 27, 2023 14:14
@fridrik01 fridrik01 requested a review from Stebalien July 27, 2023 14:17
@fridrik01 fridrik01 changed the title [WIP] feat: add new fields to message trace for supporting new trace api feat: add new fields to message trace for supporting new trace api Jul 27, 2023
@fridrik01 fridrik01 marked this pull request as ready for review July 27, 2023 14:18
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd also add the new code CID event (e.g., Invoke(Cid)) at the same time to avoid having to cut two fvm releases.

@fridrik01
Copy link
Contributor Author

LGTM but I'd also add the new code CID event (e.g., Invoke(Cid)) at the same time to avoid having to cut two fvm releases.

Added the enum as as new commit in the ref-fvm PR. I believe this does not require any changes in this repo as we just ignore unknown enums

@Stebalien
Copy link
Member

Added the enum as as new commit in the filecoin-project/ref-fvm#1823. I believe this does not require any changes in this repo as we just ignore unknown enums

Yes, but we can't merge this PR till we've cut an FVM release so we might as well finish the FVM side of things before merging this PR.

Although I guess it doesn't hurt to just cut two releases? Up to you.

@Stebalien
Copy link
Member

Blocked on a ref-fvm release.

@Stebalien Stebalien force-pushed the traceapi-new-fields branch from 07e1ac9 to 98897de Compare August 28, 2023 15:58
@fridrik01 fridrik01 merged commit bf5edd5 into master Aug 28, 2023
@fridrik01 fridrik01 deleted the traceapi-new-fields branch August 28, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants