Support Snap Deal Miner Sector Events

[frrist]

Description

With the addition of Snap Deals committed capacity upgrades will be deprecated: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0019.md#deprecation-of-current-cc-upgrade. Lily will need modification to track any new events that arise from this.

Acceptance criteria

• Figure out what is changing: Support Snap Deal Miner Sector Events #798 (comment)
• When its changing: the main network will go live with these changes sometime in late Feb or March
• If it will be run on a testnet first (so we can test lily there): Yes it is on butterfly-SnapNet: https://status.filecoin.io/
• Update lily: occurring here: Update to lotus 1.14.1 & specs-actors 7.0.0 #823

Useful links:

filecoin-project/lotus#7898

[frrist]

Tracking issue in lotus https://github.com/filecoin-project/lotus/issues?q=is%3Aopen+is%3Aissue+label%3ASnapDeals

[frrist]

What is changing?

Deprecation of current CC Upgrade: PreCommitSector will no longer be allowed to schedule current cc upgrades during prove commit. The data on chain tracking cc upgrades and the miner actor logic doing current cc upgrades will be removed. PreCommit message parameters will no longer include fields for specifying cc upgrades.

This means the following fields of the MinerPreCommitInfo model will always be null after the network upgrade:

lily/model/actors/miner/precommit.go

Lines 30 to 33 in fe9a838

	IsReplaceCapacity bool
	ReplaceSectorDeadline uint64 `pg:",use_zero"`
	ReplaceSectorPartition uint64 `pg:",use_zero"`
	ReplaceSectorNumber uint64 `pg:",use_zero"`

Note: we still need to keep them for chain processing before the upgrade. No action is required here.

---

Addition of the ProveReplicaUpdates Method on the Miner actor: a new message type once applied causes the SectorOnChainInfo struct to change for each SectorOnChainInfo in the message params (read the link for details of change)

This means:

• we can expect to see an uptick in the number of writes to the miner_sector_infos table since it contains the states of all SectorOnChainInfo for each miner and those states will be changing when the sector is snapped.
• we may see an uptick of SECTOR_EXTENDED events as storage providers extend their sector expiration's so the sector is active long enough to contain deals with once it is "snapped".
• we need to change the way we diff SectorOnChainInfos that have been modified since we only inspect the Expiration field:

  lily/chain/actors/builtin/miner/diff.go

  Line 213 in 9558021

  if siFrom.Expiration != siTo.Expiration {

  • The change will entail checking if the SectorOnChainInfo.SectorKeyCID has changed, and creating a SECTOR_SNAPPED event in the miner_sector_events table.

---

[frrist]

Also noting that SectorKeyCID can be null: https://github.com/filecoin-project/specs-actors/blob/v7.0.0-rc1/actors/builtin/miner/miner_state.go#L175, which means we need to be careful stringifying it else we'll get panics ☠️

[placer14]

This means the following fields of the MinerPreCommitInfo model will always be null after the network upgrade:
lily/model/actors/miner/precommit.go

Is there a good reason we shouldn't just use the default values (false, 0, 0, 0)? If we do, we don't complicate our schema with another domain detail, no migration, we don't have to fix whatever queries touch that table, and future queries remain simpler. Plus, indicating that IsReplaceCapacity = false (and always will be) keeps the data honest as well. Nevermind. It's already nullable. 😢

[frrist]

And we'll need to keep these around for historic reasons too, all states prior to the upgrade can set these fields.

[frrist]

closed via #823