fix(docker): Docker image build versions are no longer "dirty" #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
force-pushed
the
mg/fix/dirty-docker-builds-v2
branch
16 times, most recently
from
be8359d to
6da317b
Compare
placer14
force-pushed
the
mg/fix/dirty-docker-builds-v2
branch
12 times, most recently
from
9919ae8 to
c6209b0
Compare
Building the lily binary within the docker context makes the build
version always "dirty". This is because dockerignore omits files
from the build context which are committed into the git repo. When
these files are missing, git considers that repo "dirty".
This change allows the Makefile to use LILY_VERSION to set the build
version of the lily binary. This value used as an envvar within the
docker build environment which overrides the default ("dirty")
LILY_VERSION with the version perceived by git before dockerignore
filters/removes files from the build.
placer14
force-pushed
the
mg/fix/dirty-docker-builds-v2
branch
from
c6209b0 to
b63a99f
Compare
placer14
changed the title
placer14
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #835 +/- ##
======================================
Coverage 31.7% 31.7%
======================================
Files 39 39
Lines 3780 3780
======================================
Hits 1202 1202
Misses 2432 2432
Partials 146 146 🚀 New features to boost your workflow:
|
iand
approved these changes
Feb 4, 2022
|
@frrist if you're happy with this, it's ready to merge. LMK when you do so I can doublecheck the CI results on merge to master. :D |
|
Ship it! |
frrist
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the lily binary within the docker context makes the build
version always "dirty". This is because dockerignore omits files
from the build context which are committed into the git repo. When
these files are missing, git considers that repo "dirty".
This change allows the Makefile to use LILY_VERSION to set the build
version of the lily binary. This value used as an envvar within the
docker build environment which overrides the default ("dirty")
LILY_VERSION with the version perceived by git before dockerignore
filters/removes files from the build.