Skip to content

Conversation

placer14
Copy link
Contributor

@placer14 placer14 commented Feb 9, 2022

Fixes #847

@placer14 placer14 requested a review from frrist February 9, 2022 04:44
@placer14 placer14 self-assigned this Feb 9, 2022
@placer14 placer14 marked this pull request as draft February 9, 2022 04:48
@placer14 placer14 force-pushed the mg/fix/docker-build-libc-update branch from c26a858 to a2c8eed Compare February 9, 2022 04:54
@placer14
Copy link
Contributor Author

placer14 commented Feb 9, 2022

I added a test here to ensure docker images are executable. Once they are confirmed to properly fail, I'll apply the fix commit and confirm they turn green.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.8%. Comparing base (beea5b7) to head (fbb7482).
⚠️ Report is 289 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #848   +/-   ##
======================================
  Coverage    31.8%   31.8%           
======================================
  Files          39      39           
  Lines        3785    3785           
======================================
  Hits         1207    1207           
  Misses       2432    2432           
  Partials      146     146           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@placer14 placer14 marked this pull request as ready for review February 9, 2022 05:07
@placer14 placer14 force-pushed the mg/fix/docker-build-libc-update branch from 6f16d3c to 940530a Compare February 9, 2022 15:47
@placer14
Copy link
Contributor Author

placer14 commented Feb 9, 2022

💥

Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me how this fixes and libc mismatch, is it related to bookworm-curl?

Also, go ahead and target master with this fix and I'll rebaase the rc branch onto it once it's in.

@placer14 placer14 changed the base branch from frrist/update-lotusv1.14.0-rc4 to master February 9, 2022 20:14
@placer14
Copy link
Contributor Author

placer14 commented Feb 9, 2022

My best guess is that the go1.17 environment uses a newer libc than what buildpack-deps:buster-curl has by default. :bookworm-curl has a later version of libc to match what the go1.17-built binary expects.

@placer14 placer14 force-pushed the mg/fix/docker-build-libc-update branch from 940530a to fbb7482 Compare February 9, 2022 20:20
@frrist frrist merged commit b496364 into master Feb 11, 2022
@frrist frrist deleted the mg/fix/docker-build-libc-update branch February 11, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-calibnet builds result in lily binary which cannot run
3 participants