fix: error marshalling in processing reports #855
Conversation
frrist
force-pushed
the
frrist/fix-process-error-message
branch
from
988f3e7 to
458e7ea
Compare
| "go.opencensus.io/tag" | ||
| "go.opentelemetry.io/otel" | ||
| "go.opentelemetry.io/otel/attribute" | ||
| "golang.org/x/xerrors" |
There was a problem hiding this comment.
Nothing changing here, just updated my editor.
| res.Report[idx].ErrorsDetected = &struct { | ||
| Error string | ||
| }{Error: e.Error()} | ||
| } |
There was a problem hiding this comment.
Is it worth putting a placeholder for Error if it can't be extracted? Something like "invalid/empty error detail" or similar?
There was a problem hiding this comment.
Humm we could probably do that, but it would mean enforcing everything that writes to the struct filed being an error since it can contain types that do not implement the error interface:
Lines 164 to 170 in fe9a838
I'm not sure what the best way to enforce that would be, I'm not sure if the ErrorsDetected filed can be type error due to go-pg. What do you think?
There was a problem hiding this comment.
I'm going to get this merged, but please continue here if anything comes to mind.
Uh oh!
There was an error while loading. Please reload this page.