Skip to content

Conversation

placer14
Copy link
Contributor

@placer14 placer14 commented Feb 16, 2022

This PR enables continuous delivery triggers into our infrastructure repos. There are a few changes included:

  • separate docker image publishing into parallel jobs
  • fix calibnet and butterflynet docker builds
  • docker image builds trigger on
    • tags containing dev
    • branch names containing deploy
  • include job which triggers the pipeline in the infra repo. Deployments trigger on
    • tags containing dev
    • branch names containing deploy

@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch 6 times, most recently from a4f4195 to e8d68ea Compare February 16, 2022 18:38
@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch from e8d68ea to 4a5e681 Compare February 16, 2022 18:40
@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch 2 times, most recently from 35a876f to 0e772c3 Compare February 16, 2022 19:26
@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch from 0e772c3 to 1a7eaa7 Compare February 16, 2022 19:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.8%. Comparing base (67aafb5) to head (f229518).
⚠️ Report is 286 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #868   +/-   ##
======================================
  Coverage    31.8%   31.8%           
======================================
  Files          39      39           
  Lines        3790    3790           
======================================
  Hits         1207    1207           
  Misses       2437    2437           
  Partials      146     146           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch 9 times, most recently from 4aa8625 to 7922bf8 Compare February 16, 2022 22:40
@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch from b8a7a37 to 19055d6 Compare February 16, 2022 23:29
@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch from 8f7339a to 572aa4a Compare February 17, 2022 03:32
@placer14 placer14 force-pushed the mg/feat/rc-tags-trigger-deployments branch from 572aa4a to f229518 Compare February 17, 2022 03:57
@placer14 placer14 requested a review from frrist February 17, 2022 05:15
@placer14 placer14 requested a review from iand February 17, 2022 05:15
@placer14 placer14 changed the title feat(ci): CD of release candidate tags to staging EKS feat(ci): CD of RC tags and deploy branches Feb 17, 2022
@placer14 placer14 changed the title feat(ci): CD of RC tags and deploy branches feat(ci): Continuous deployment for tags and deploy branches Feb 17, 2022
@placer14 placer14 marked this pull request as ready for review February 17, 2022 05:17
Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!
Approving on the assumption this has been manually verified to work.

docker image builds trigger on

Is this a change from the original behavior? Prior to this change didn't we always build docker containers?

- checkout
- setup_remote_docker:
docker_layer_caching: true
version: "20.10.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth making this value a constant we set once.

@placer14
Copy link
Contributor Author

placer14 commented Feb 23, 2022

docker image builds trigger on

Is this a change from the original behavior? Prior to this change didn't we always build docker containers?

The prior behavior has not changed. This behavior I outlined is new and is required to support the special branch/tag deployment cases (which also need docker images to deploy other than the usual builds).

@placer14 placer14 merged commit 981dde8 into master Feb 23, 2022
@placer14 placer14 deleted the mg/feat/rc-tags-trigger-deployments branch February 23, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants