-
Notifications
You must be signed in to change notification settings - Fork 47
feat(ci): Continuous deployment for tags and deploy branches #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a4f4195
to
e8d68ea
Compare
e8d68ea
to
4a5e681
Compare
35a876f
to
0e772c3
Compare
0e772c3
to
1a7eaa7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
======================================
Coverage 31.8% 31.8%
======================================
Files 39 39
Lines 3790 3790
======================================
Hits 1207 1207
Misses 2437 2437
Partials 146 146 🚀 New features to boost your workflow:
|
4aa8625
to
7922bf8
Compare
b8a7a37
to
19055d6
Compare
8f7339a
to
572aa4a
Compare
572aa4a
to
f229518
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
Approving on the assumption this has been manually verified to work.
docker image builds trigger on
Is this a change from the original behavior? Prior to this change didn't we always build docker containers?
- checkout | ||
- setup_remote_docker: | ||
docker_layer_caching: true | ||
version: "20.10.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth making this value a constant we set once.
The prior behavior has not changed. This behavior I outlined is new and is required to support the special branch/tag deployment cases (which also need docker images to deploy other than the usual builds). |
This PR enables continuous delivery triggers into our infrastructure repos. There are a few changes included:
dev
deploy
dev
deploy