Skip to content

Conversation

frrist
Copy link
Member

@frrist frrist commented Feb 25, 2022

This change is required to prevent nil models from the actorstatesminer task from being persisted, e.g.:

{"level":"error","ts":"2022-02-25T20:45:10.165Z","logger":"lily/chain","caller":"chain/indexer.go:506","msg":"persistence failed","current":725047,"next":725048,"task":"actorstatesminer","error":"persisting model: pg: Model(nil)","errorVerbose":"persisting model:\n    github.com/filecoin-project/lily/storage.(*TxStorage).PersistModel\n        /go/src/github.com/filecoin-project/lily/storage/sql.go:428\n  - pg: Model(nil)"}

was found in calibnet staging

@frrist frrist self-assigned this Feb 25, 2022
@frrist frrist requested review from iand and kasteph February 25, 2022 21:17
@codecov-commenter
Copy link

Codecov Report

Merging #882 (5659450) into master (90da017) will not change coverage.
The diff coverage is 0.0%.

@@          Coverage Diff           @@
##           master    #882   +/-   ##
======================================
  Coverage    31.2%   31.2%           
======================================
  Files          39      39           
  Lines        3865    3865           
======================================
  Hits         1209    1209           
  Misses       2510    2510           
  Partials      146     146           

@frrist frrist merged commit f283216 into master Feb 25, 2022
@frrist frrist deleted the frrist/fix-miner-task-persist branch February 25, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants