-
Notifications
You must be signed in to change notification settings - Fork 47
fix: get missing tasks for each height. #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b9c8016
to
c267781
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
========================================
- Coverage 31.2% 29.5% -1.7%
========================================
Files 39 39
Lines 3873 3726 -147
========================================
- Hits 1209 1102 -107
+ Misses 2518 2481 -37
+ Partials 146 143 -3 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, but I'm not clear on what the motivation for this change is or what this intends to fix/improve. Is there an issue or could we include a description in the PR?
Most glaring here is the value of the dense rank isn't clear to me (yet). (Also, very sorry for the late review. 🙏)
This PR came about from a one-off conversation between @kasteph and myself. There isn't an issue tracking this, as it's mostly explorative work. The tentative next steps are refactoring the gap-find query into a single SQL function. @kasteph I've converted this to a draft to signal this, hope that's alright with you. |
@frrist sounds good, thanks! |
bbe1fb7
to
a0ca674
Compare
27be204
to
732d41d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goood stuff! Excited to have this. Please address comments before merging.
No description provided.