fix: state cache falls through to slow path on error #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
======================================
Coverage 31.2% 31.2%
======================================
Files 39 39
Lines 3865 3865
======================================
Hits 1209 1209
Misses 2510 2510
Partials 146 146 |
frrist
approved these changes
Mar 3, 2022
| @@ -1,54 +0,0 @@ | |||
| # This file was generated with `make docker-files` and should not | |||
There was a problem hiding this comment.
You're probably aware - undo this change.
There was a problem hiding this comment.
Hmm. make clean deletes this file so what is the expected pattern for building? Do I need to regerenate the dockerfiles and recommit every time?
| @@ -1,42 +0,0 @@ | |||
| # This file was generated with `make docker-files` and should not | |||
lens/util/store.go
Outdated
| } | ||
|
|
||
| if !value.(reflect.Value).Type().AssignableTo(o.Type()) { | ||
| return xerrors.Errorf("out parameter cannot be assigned cached value") |
There was a problem hiding this comment.
include the types in the error message
lens/util/store.go
Outdated
| func (cas *CachingStateStore) tryAssign(value interface{}, out interface{}) error { | ||
| o := reflect.ValueOf(out).Elem() | ||
| if !o.CanSet() { | ||
| return xerrors.Errorf("out parameter cannot be set") |
|
@frrist restored dockerfiles |
|
Looks good, my approval is sticky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents cache failures causing extraction to fail