Skip to content

Conversation

frrist
Copy link
Member

@frrist frrist commented Mar 4, 2022

I don't know if this will actually parse the params correctly, need to verify still, but it will at least prevent the daemon from panicing and return a more helpful error message.

@frrist frrist requested a review from iand March 4, 2022 22:30
@frrist frrist self-assigned this Mar 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.2%. Comparing base (0549483) to head (ec4803f).
⚠️ Report is 276 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #888   +/-   ##
======================================
  Coverage    31.2%   31.2%           
======================================
  Files          39      39           
  Lines        3865    3865           
======================================
  Hits         1209    1209           
  Misses       2510    2510           
  Partials      146     146           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frrist frrist force-pushed the frrist/fix-msg-param-panic branch from 44d927b to ec4803f Compare March 7, 2022 18:48
@frrist frrist merged commit b65a741 into master Mar 7, 2022
@frrist frrist deleted the frrist/fix-msg-param-panic branch March 7, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic while parsing message params
3 participants