Skip to content

Conversation

frrist
Copy link
Member

@frrist frrist commented Mar 7, 2022

parsed_messages after apply this fix:

+--------------------------------------------------------------+------+--------------------------------------------------------------------------------------+-----------------------------------------+-----+------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|cid                                                           |height|from                                                                                  |to                                       |value|method            |params                                                                                                                                                                                                                                                                                                                                                                                                                              |
+--------------------------------------------------------------+------+--------------------------------------------------------------------------------------+-----------------------------------------+-----+------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|bafy2bzacebrh4pe2apyid7rs64gn7minhv5jcsbuouovnza6ythsgq7cse2j2|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 3, "Extra": null, "Nonce": 62, "Amount": {"Int": 3982288084}, "Merges": null, "Signature": {"Data": "lyN1JbMwMg1QHkKtXUADKIhQwY27k4mMgAUMr2ZVPUq4IMbXHB+nN/JOGTZ9WRHLEe0yDnNAGOgLV8/GnsP8WjFjds+OUHpYhsh0hJoMFPF1rhru4uwHwXc5U3fDe1Wk", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}  |
|bafy2bzacebebz6acyuaaqt2dd34pgusriluvmz76523e7pvarbcc57lwjkar4|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 4, "Extra": null, "Nonce": 107, "Amount": {"Int": 11938098236}, "Merges": null, "Signature": {"Data": "rH0bqFZOJzEicEEjqCVXPN9qSSBueW1bIVDMWXbHI3uHrIIj832FI8vNrfch1GfYCk+9pXNaOoM5TXx1WeJIudk4p1K9bOKyxhZXWWA1Nzy5sGPzbExDMpvHtf+CL4Gr", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}|
|bafy2bzacea536daac45rlgnlm6v2gmao7aesrvwv5pvyzkxrk7ayx7jajzvy6|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 5, "Extra": null, "Nonce": 87, "Amount": {"Int": 7960172680}, "Merges": null, "Signature": {"Data": "laXIO/WJIRZjBLMXI0mtCj8ehLrAc6AJRPiDrM8XVlZxPNRqt4rNoRNHPYaYR+U2EhG9XQH6BCl5SyKjR3yaEAB3En/5qe8+CaIBJUC2jqqschxWfhDxTbcQIWuJ5yqM", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}  |
|bafy2bzaceaprkk4eub6gnxqium4wcjk5o675gwfgdzxm7by33zkheusmadi2a|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 2, "Extra": null, "Nonce": 62, "Amount": {"Int": 3977905096}, "Merges": null, "Signature": {"Data": "jycwIhq3W1LsQjy9Vh0YSIAcRkUNOuzRcX3/hbIXRqVZt+kdF9WAzTQw7glInNVaFjvZTblxZruMpyWk7Au3zFHMAG+Y0yecYznp2NK1caLTs6ejVMBhCJylNTEv7TQ5", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}  |
|bafy2bzacecovzurhi4h6ti6cr6aqns3y3u3mswtjyk5jxeass7xetxgzxmvsq|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 1, "Extra": null, "Nonce": 2, "Amount": {"Int": 4343616}, "Merges": null, "Signature": {"Data": "rGo+cY4jym6PBnHp9Mj8WXxb60QLkOjZiCZ9pKjKlC1tGZysMYz7LyC8LcxMQLmvBzuNiPMcoM+QmdtrqGNCwTDaLlHNR+WtWKR0fwtrVhvCmKzru10inx2S5eyeE1fr", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}      |
|bafy2bzaced6ra72qcfue44qmrumjslhrxolzenbfub5nz6w6rt4pabkvarobi|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 0, "Extra": null, "Nonce": 2, "Amount": {"Int": 4399392}, "Merges": null, "Signature": {"Data": "kXWudf8NPL74MmJfWpdEPWXOne/F1v6L9mxLRmqGrxyJfcEmkDtnBP/kdoa0/fmQDS3x6m/xDEGGdY1jGHGju1b34thjpVH25MP2f48Lrr/n4/vMAm4kKwR3mAo4Z4RW", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}      |
|bafy2bzaceban4nrhvv6icllbfvks6vejpm3g57qx3h52tpg7mxgwpaf2ybz6a|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 7, "Extra": null, "Nonce": 87, "Amount": {"Int": 7960172680}, "Merges": null, "Signature": {"Data": "iJ3ln6QaMb5QKK16oNMq5X6f36l/651iFgspysb0jKEAjJpLIe5cPCAT2zEx4WmqAFGVkhrgiTOg1jDJIgnh+OgYBOGOgHO6doV8J8whg2zkubaYlsLICdcZjpyGUvq9", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}  |
|bafy2bzaceahzeoc3svzoe6aa7j2m5p6o2c5kmjxhoo25gajinxz2f25i6q4kw|435326|t3tbpxmkoleewaphwounptqe2ypfz75pg2zxugk7zfyseggrxhggm242bybeywtszezruyc4anzaicahy2c55q|t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky|0    |UpdateChannelState|{"Sv": {"Lane": 6, "Extra": null, "Nonce": 87, "Amount": {"Int": 7960172680}, "Merges": null, "Signature": {"Data": "rm9VcNjZrn2MMkCMsQsPSRWjtmVud+ARR1lXSRsM13fTsSeeuoaImDxLTc4UJMwfEZFz/TuunrzhSqiKHfVbq5RHKTw9g4ZusbNlSUgk5VTXgfiIW1IBLHG1fGSqopUs", "Type": 2}, "ChannelAddr": "t2agxsfeq274rqk5f2mduseovdmrpxv52r6gp4mky", "TimeLockMax": 0, "TimeLockMin": 0, "SecretPreimage": null, "MinSettleHeight": 0}, "Secret": null}  |
+--------------------------------------------------------------+------+--------------------------------------------------------------------------------------+-----------------------------------------+-----+------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

@frrist frrist requested a review from iand March 7, 2022 20:26
@frrist frrist self-assigned this Mar 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #893 (59ee9ba) into master (3344dc4) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #893   +/-   ##
======================================
  Coverage    31.2%   31.2%           
======================================
  Files          39      39           
  Lines        3865    3865           
======================================
  Hits         1209    1209           
  Misses       2510    2510           
  Partials      146     146           

wantEncoded: "{\"Recoveries\":[{\"Deadline\":1,\"Partition\":1,\"Sectors\":{\"Count\":10,\"RLE\":[1,10]}}]}",
wantErr: false,
},
// from https://github.com/filecoin-project/lily/issues/892
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without 691f5c2 I have verified this test fails with:

message_test.go:292: got unexpected error: failed to parse message params method: 2, actor code: bafkqafdgnfwc6nrpobqxs3lfnz2gg2dbnzxgk3a, params: ��U���"���#�t�`�":�d_z�Q��@���WF���v����Xa��oUp�ٮ}�2@����I���enw��GYWI��wӱ'�����<KM��$����s�;����J����[��G)<=��n��eIH$�Tׁ��[R�,q�|d���,@: failed to override message param json marshaller: reflect: call of reflect.Value.NumField on zero Value

@frrist frrist merged commit 225d8f5 into master Mar 7, 2022
@frrist frrist deleted the frrist/fix-msg-param-nil-value branch March 7, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message Param Parsing fails due to zero value
3 participants