Skip to content

fix: return error when to and from are invalid #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix: return error when to and from are invalid #906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions commands/export.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ import (
"os"

"github.com/filecoin-project/go-state-types/abi"
"github.com/filecoin-project/lily/chain/export"
"github.com/filecoin-project/lotus/blockstore"
"github.com/filecoin-project/lotus/chain/store"
"github.com/filecoin-project/lotus/node/repo"
"github.com/mitchellh/go-homedir"
"github.com/urfave/cli/v2"
"golang.org/x/xerrors"

"github.com/filecoin-project/lily/chain/export"
)

type chainExportOps struct {
Expand Down Expand Up @@ -109,7 +110,7 @@ Some examples:
Before: func(cctx *cli.Context) error {
from, to := chainExportFlags.from, chainExportFlags.to
if to < from {
xerrors.Errorf("value of --to (%d) should be >= --from (%d)", to, from)
return xerrors.Errorf("value of --to (%d) should be >= --from (%d)", to, from)
}

return nil
Expand Down
7 changes: 4 additions & 3 deletions commands/gap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ import (
"strings"
"time"

"github.com/filecoin-project/lily/chain"
"github.com/filecoin-project/lily/lens/lily"
lotuscli "github.com/filecoin-project/lotus/cli"
"github.com/urfave/cli/v2"
"golang.org/x/xerrors"

"github.com/filecoin-project/lily/chain"
"github.com/filecoin-project/lily/lens/lily"
)

type gapOps struct {
Expand Down Expand Up @@ -91,7 +92,7 @@ var GapFillCmd = &cli.Command{
Before: func(cctx *cli.Context) error {
from, to := gapFlags.from, gapFlags.to
if to < from {
xerrors.Errorf("value of --to (%d) should be >= --from (%d)", to, from)
return xerrors.Errorf("value of --to (%d) should be >= --from (%d)", to, from)
}

return nil
Expand Down
7 changes: 4 additions & 3 deletions commands/walk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ import (
"strings"
"time"

"github.com/filecoin-project/lily/chain/actors/builtin"
"github.com/filecoin-project/lily/lens/lily"
lotuscli "github.com/filecoin-project/lotus/cli"
"github.com/urfave/cli/v2"
"golang.org/x/xerrors"

"github.com/filecoin-project/lily/chain/actors/builtin"
"github.com/filecoin-project/lily/lens/lily"

"github.com/filecoin-project/lily/chain"
)

Expand Down Expand Up @@ -92,7 +93,7 @@ var WalkCmd = &cli.Command{
Before: func(cctx *cli.Context) error {
from, to := walkFlags.from, walkFlags.to
if to < from {
xerrors.Errorf("value of --to (%d) should be >= --from (%d)", to, from)
return xerrors.Errorf("value of --to (%d) should be >= --from (%d)", to, from)
}

return nil
Expand Down