Skip to content

Conversation

frrist
Copy link
Member

@frrist frrist commented Apr 14, 2022

@frrist frrist marked this pull request as ready for review April 20, 2022 01:52
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #929 (f85dbaa) into master (df1f31e) will decrease coverage by 0.6%.
The diff coverage is 19.1%.

@@           Coverage Diff            @@
##           master    #929     +/-   ##
========================================
- Coverage    37.0%   36.4%   -0.7%     
========================================
  Files          25      27      +2     
  Lines        1802    1854     +52     
========================================
+ Hits          667     675      +8     
- Misses       1060    1104     +44     
  Partials       75      75             

@frrist frrist force-pushed the frrist/distributed-worker-pattern branch from 642e425 to 171dd5b Compare April 21, 2022 01:22
@frrist frrist requested a review from placer14 April 21, 2022 15:19
Copy link
Contributor

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a pleasure to read. Minor comments and suggestions. Sticky approval.

@frrist frrist force-pushed the frrist/distributed-worker-pattern branch from 171dd5b to c1f629a Compare April 22, 2022 23:58
@frrist frrist force-pushed the frrist/distributed-worker-pattern branch from 810cccc to fc21568 Compare April 26, 2022 23:43
@frrist frrist self-assigned this Apr 26, 2022
@frrist frrist merged commit a35ae36 into master Apr 26, 2022
@frrist frrist deleted the frrist/distributed-worker-pattern branch April 26, 2022 23:53
frrist added a commit to filecoin-project/helm-charts that referenced this pull request Apr 26, 2022
placer14 added a commit to filecoin-project/helm-charts that referenced this pull request May 11, 2022
* feat: add config values for queue

- required by: filecoin-project/lily#929

* feat(lily): Allow inline config for Lily deployment

Co-authored-by: Mike Greenberg <placer14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-architect Lily for horizontal: diff extraction, diff storage, diff processing.
3 participants