-
Notifications
You must be signed in to change notification settings - Fork 47
Lily distributed worker pattern #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
========================================
- Coverage 37.0% 36.4% -0.7%
========================================
Files 25 27 +2
Lines 1802 1854 +52
========================================
+ Hits 667 675 +8
- Misses 1060 1104 +44
Partials 75 75 |
642e425
to
171dd5b
Compare
placer14
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a pleasure to read. Minor comments and suggestions. Sticky approval.
171dd5b
to
c1f629a
Compare
- refactor package to make boundaries clearer
810cccc
to
fc21568
Compare
frrist
added a commit
to filecoin-project/helm-charts
that referenced
this pull request
Apr 26, 2022
- required by: filecoin-project/lily#929
placer14
added a commit
to filecoin-project/helm-charts
that referenced
this pull request
May 11, 2022
* feat: add config values for queue - required by: filecoin-project/lily#929 * feat(lily): Allow inline config for Lily deployment Co-authored-by: Mike Greenberg <placer14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of https://www.notion.so/pl-strflt/Distributed-Lily-Worker-Pattern-bbf101e392144e4184fae1ef7074ee02